From Fedora Project Wiki
m (Undo revision 483196 by Psabata (talk))
 
(25 intermediate revisions by 3 users not shown)
Line 46: Line 46:


* Targeted release: [[Releases/25 | Fedora 25 ]]  
* Targeted release: [[Releases/25 | Fedora 25 ]]  
* Last updated: 2016-04-14
* Last updated: 2016-07-26
<!-- After the change proposal is accepted by FESCo, tracking bug is created in Bugzilla and linked to this page  
<!-- After the change proposal is accepted by FESCo, tracking bug is created in Bugzilla and linked to this page  
Bugzilla states meaning as usual:
Bugzilla states meaning as usual:
Line 55: Line 55:
CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development
CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development
-->
-->
* Tracker bug:  
* Tracker bug: [https://bugzilla.redhat.com/show_bug.cgi?id=1332102 #1332102]


=== Completed items ===
=== Completed items ===
* [https://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies Perl packaging guidelines update on build-requires] approved
* perl.spec changed to bootstrap without perl-generators [http://pkgs.fedoraproject.org/cgit/rpms/perl.git/commit/?id=c1d0a9658155c0f512faad7b54e20e00f3d682e3]
* perl-Fedora-VSP changed to bootstrap without perl-generators [http://pkgs.fedoraproject.org/cgit/rpms/perl-Fedora-VSP.git/commit/?id=47ccd3c726f2459d8221511173db969eef174d93]
* perl-generators changed to bootstrap without perl-generators [http://pkgs.fedoraproject.org/cgit/rpms/perl-generators.git/commit/?id=eac57436d0ea93c904c33f3d9eefc0a3103c2187]
* perl-generators run-requires perl-macros [http://pkgs.fedoraproject.org/cgit/rpms/perl-generators.git/commit/?id=6cbe1ae5e0fb2ef4d7262dcf8050bacf4c018e2c]
* Create [https://pagure.io/RPM-SpecEditor/tree/master tool for editing spec files]
* Enhance Fedora-Rebuild for editing source repositories [http://repo.or.cz/Fedora-Rebuild.git/blob/HEAD:/bin/rebuildedit]
* Gather all packages requiring or providing a Perl module: 3292 packages
* Gather all packages requiring libperl.so: 491 packages
* Inject perl-devel and perl-generators into local copy: 3129 packages
* Test locally modified packages: 34 packages failed to rebuild, none of because spec file changes
* <code>BuildRequires: perl-generators</code> added into package that use perl() RPM dependency symbols and do not build-require perl-generators yet.
* <code>BuildRequires: perl-devel</code> added into packages that run-require libperl.so and do not build-require perl-devel yet.
* 3121 packages were edited.
* Add [https://bugzilla.redhat.com/show_bug.cgi?id=1110823#c8 dummy perl-generators package into EPEL to ease porting from Fedora]
* [https://bugzilla.redhat.com/show_bug.cgi?id=1158860 Remove perl-generators dependency from rpm-build.] It saves 20 MB on x86_64.


=== Items in progress ===
=== Items in progress ===
* Check rebuilt packages for dependencies.


=== Items to be done ===
=== Items to be done ===
* Gather all packages requiring or providing a Perl module.
* Add <code>BuildRequires: perl-generators</code> into all of them that do not build-require it yet.
* Remove perl-generators dependency from rpm-build.
* Check rebuilt packages for dependencies


== Detailed Description ==
== Detailed Description ==


When building a package in the Fedora build system ([https://koji.fedoraproject.org/koji/ Koji]), a predefined set of packages together with their dependencies is always installed. This is called minimal build root and it occupies about 527 MB now. In order to make it smaller, [https://bugzilla.redhat.com/show_bug.cgi?id=1158860 perl-generators dependency will be removed from rpm-build package]. This effectively removed Perl packages from minimal build root (about 20 MB now).
When building a package in the Fedora build system ([https://koji.fedoraproject.org/koji/ Koji]), a predefined set of packages together with their dependencies is always installed. This is called minimal build root and it occupies about 527 MB now. In order to make it smaller, [https://bugzilla.redhat.com/show_bug.cgi?id=1158860 perl-generators dependency will be removed from rpm-build package]. This effectively removes Perl packages from minimal build root (about 20 MB now).


However, this will break building all Perl packages as almost no Perl package build-requires perl-generators and thus these packages will miss auto-generated dependencies between Perl modules (perl() namespace in RPM dependency symbols).
However, this will break building all Perl packages as almost no Perl package build-requires perl-generators and thus these packages will miss auto-generated dependencies between Perl modules (perl() namespace in RPM dependency symbols).
Line 79: Line 91:


Build root without Perl will allow faster and safer package building.
Build root without Perl will allow faster and safer package building.
It will save build time (less amount of packages have to be downloaded and installed to a builder), disk space (about 20 megabytes), maintenance (less code in the build root means lower risk of breakage). It will improve not only the already fast Koji. It's also good for packagers running mock tool on their machines far away from mirrors.


== Scope ==
== Scope ==
Line 115: Line 129:


== Documentation ==
== Documentation ==
* [http://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org/message/QDPPEZ32JWR4WSSJ6XR2XHGCAN3WAGUT/ Discussion on perl-devel mailing list]
* [https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org/thread/QDPPEZ32JWR4WSSJ6XR2XHGCAN3WAGUT/ Discussion on perl-devel mailing list]
* [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/MVWJSGRERJAICHD56WVMB7GEDTLG3M6K/ Discussion on Fedora devel mailing list]
* [https://fedorahosted.org/fpc/ticket/620 Fedora Packaging Committee request for Perl Build-Requires Packaging guidelines update]
* [https://fedoraproject.org/wiki/PackagingDrafts/Packaging:Perl/BuildRequires Perl Packaging guidelines draft]
* [https://fedoraproject.org/wiki/PackagingDrafts/Packaging:Perl/BuildRequires Perl Packaging guidelines draft]
* [https://fedoraproject.org/wiki/Packaging:Perl Perl Packaging guidelines]
* [https://fedoraproject.org/wiki/Packaging:Perl Perl Packaging guidelines]


== Release Notes ==
== Release Notes ==
Perl was removed from minimal build root. This change is visible for Fedora package maintainers only. If you maintain a Fedora package that uses Perl at build time or delivers a Perl code, please follow updated [https://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies Perl packaging guidelines on build dependencies].


[[Category:ChangePageIncomplete]]
[[Category:ChangeAcceptedF25]]
<!-- When your change proposal page is completed and ready for review and announcement -->
<!-- When your change proposal page is completed and ready for review and announcement -->
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler -->

Latest revision as of 17:29, 3 January 2017


Removing Perl from Build Root

Summary

This change aims to removing Perl from minimal build root.

Owner

Current status

Completed items

  • Perl packaging guidelines update on build-requires approved
  • perl.spec changed to bootstrap without perl-generators [1]
  • perl-Fedora-VSP changed to bootstrap without perl-generators [2]
  • perl-generators changed to bootstrap without perl-generators [3]
  • perl-generators run-requires perl-macros [4]
  • Create tool for editing spec files
  • Enhance Fedora-Rebuild for editing source repositories [5]
  • Gather all packages requiring or providing a Perl module: 3292 packages
  • Gather all packages requiring libperl.so: 491 packages
  • Inject perl-devel and perl-generators into local copy: 3129 packages
  • Test locally modified packages: 34 packages failed to rebuild, none of because spec file changes
  • BuildRequires: perl-generators added into package that use perl() RPM dependency symbols and do not build-require perl-generators yet.
  • BuildRequires: perl-devel added into packages that run-require libperl.so and do not build-require perl-devel yet.
  • 3121 packages were edited.
  • Add dummy perl-generators package into EPEL to ease porting from Fedora
  • Remove perl-generators dependency from rpm-build. It saves 20 MB on x86_64.

Items in progress

  • Check rebuilt packages for dependencies.

Items to be done

Detailed Description

When building a package in the Fedora build system (Koji), a predefined set of packages together with their dependencies is always installed. This is called minimal build root and it occupies about 527 MB now. In order to make it smaller, perl-generators dependency will be removed from rpm-build package. This effectively removes Perl packages from minimal build root (about 20 MB now).

However, this will break building all Perl packages as almost no Perl package build-requires perl-generators and thus these packages will miss auto-generated dependencies between Perl modules (perl() namespace in RPM dependency symbols).

To prevent from havoc, Perl Packaging guidelines will be updated and all packages the deliver a Perl code will be updated to build-require perl-generators.

Benefit to Fedora

Build root without Perl will allow faster and safer package building.

It will save build time (less amount of packages have to be downloaded and installed to a builder), disk space (about 20 megabytes), maintenance (less code in the build root means lower risk of breakage). It will improve not only the already fast Koji. It's also good for packagers running mock tool on their machines far away from mirrors.

Scope

Every Perl package spec file will be modified in the master git branch.

  • Proposal owners:

Maintainers of rpm package to remove dependency on perl-generators. Perl maintainers to insert missing build-requirement on perl-generators into all Perl packages.

  • Other developers:

Owners of packages that fail to rebuild, mainly perl-sig users, will be asked using Bugzilla to fix their packages.

  • Release engineering:

Not involved.

  • Policies and guidelines:

Perl packaging guidelines will be updated to mandate dependency on perl-generators for Perl packages.

Upgrade/compatibility impact

There should no visible change to package compatibility in Fedora. It's possible that some old EPEL targets do not have standalone perl-generators, therfore maintainers will have to adjust their spec files when merging them from Fedora to EPEL.

How To Test

Compare Requires and Provides of Perl packages that were rebuilt after removing Perl from the build root. They should be the same.

User Experience

There should not be any remarkable change in user experience.

Dependencies

There is more than 2800 packages depending on perl. None of them are expected to break. Finishing this change can be endangered only by change in minimal build root packages that would gained a new dependency on Perl. Not finishing this change should not affect user experience.

Contingency Plan

We reintroduce rpm-build run-time dependency on perl-generators.

  • Contingency deadline: branching Fedora 25 from Rawhide.
  • Blocks release? No.

Documentation

Release Notes

Perl was removed from minimal build root. This change is visible for Fedora package maintainers only. If you maintain a Fedora package that uses Perl at build time or delivers a Perl code, please follow updated Perl packaging guidelines on build dependencies.