Document Details
- Status:WORKING DRAFT:
- Point of contact: Pingou
- Implementation Schedule: TBD
- Release Date: TBD
Goals
We want to gate packages on test results before they can land in rawhide. This will reduce the amount of broken dependency, uninstallable packages and broken composes leading to a more stable rawhide as well as less work on the infrastructure and rel-eng teams to keep composes working. The benefits to Fedora for implementing this:
- As more packagers opt-into gating and add tests to their packages, rawhide becomes more stable
- More stable rawhide will lead to easier composes and a smoother release process
- Ability to use chain-build in rawhide and stable releases
Background and Strategic Fit
Currently composing rawhide is often broken leading to a poor user-experience as well as impacting the release engineering team when trying to run a compose on rawhide.
By gating how rawhide packages land into rawhide and its buildroot we will be able to offer a more stable rawhide and reduce the workload when we branch and are getting ready to release.
Packages having tests are already being tested for every commit made to their repository. These results are then made available in bodhi on the update's page. In addition, if a pull-request is opened on https://src.fedoraproject.org against one of these packages, the tests are ran and their outcome indicated as a flag on the pull-request page.
The principle of this proposal is to set the infrastructure allowing to gate packages, how the packages are gated (ie: on which tests) is out of scope and will be a policy (FESCo) decision once the tooling and workflow is put in place.
People involved
This project impacts a number of application or other projects. Here is a quick list of the different projects involved and their point of contact.
- Coordinator: Pierre-Yves Chibon
- Bodhi: Randy Barlow and Aurélien Bompard
- koji: Mikolaj Izdebski and Mike McLean
- fedpkg/rpkg: Chenxiong and Lubomír Sedlář
- Fedora CI: Dominik Perpeet
Assumptions
Are there any assumptions for completing this work?
Additional Links
Change proposal: https://fedoraproject.org/wiki/Changes/GatingRawhidePackages
Initial User Story
A minimum user story list should be prepared here to facilitate Task Breakdown. The user story describes the type of user, what they want and why. A user story helps to create a simplified description of a requirement. Format should be:
As a < type of user >, I want < some goal > so that < some reason >.
Task breakdown
This is a shorthand list of items we are needing to cover for building Rawhide Gating in Fedora Infrastructure for the Fiscal Year 2020.
Bodhi
- Single package update
- We will need to write a message-bus listener that will automatically create a bodhi update for each package built in the rawhide-gated tag.
- We will need to write a message-bus listener to automatically push bodhi updates created for rawhide that have passed CI (the decision being announced by Greenwave).
- Multi package update
- We will need to allow bodhi to create a new update from a specified side-tag instead of a list of builds.
- We will need to write a message-bus listener that, upon greenwave notifications about an update created from a side-tag passing CI, will move all of its builds into the rawhide-candidate tag and clean the side-tag created for this update.
- We will need to write a script that regularly clean old side-tags left around
Koji
- We will need a koji plugin allowing packagers to create new side-tags
fedpkg/rpkg
- We will need to add support for the command:
fedpkg side-tag createwhich will create a new side-tag in koji for this user using the new plugin - We will need to add support for the command:
fedpkg side-tag mergewhich will call bodhi to ask it to create an update corresponding to this side-tag- Alternatively: Expand the existing
fedpkg updatecommand to add support for creating a new update from a side-tag
- Alternatively: Expand the existing