From Fedora Project Wiki
(Add a could as recommended by FESCo)
 
Line 8: Line 8:
Anything in the spec file which is not obvious should have a comment explaining it.
Anything in the spec file which is not obvious should have a comment explaining it.


Some examples of non-obvious items include (but are not limited to):
Some examples of non-obvious items could include (but are not limited to):
* Some explicit requires  
* Some explicit requires  
* Changes to optflags
* Changes to optflags

Latest revision as of 18:01, 20 February 2009

Addition to ReviewGuidelines

SHOULD: Anything in the spec file which is not obvious should have a comment explaining it.

Addition to Packaging Guidelines

Non-Obvious Items in Spec Files

Anything in the spec file which is not obvious should have a comment explaining it.

Some examples of non-obvious items could include (but are not limited to):

  • Some explicit requires
  • Changes to optflags
  • Not using %configure or make install
  • Provides/Obsoletes
  • Modified tarballs
  • Licensing or legal related changes