|
|
| (14 intermediate revisions by 3 users not shown) |
| Line 1: |
Line 1: |
| {{needs love}}
| |
|
| |
|
| ReviewTool is a script designed to help with submitting and reviewing packages... It leverages the standard infrastructure tools (e.g., [[Koji]], [[Bugzilla]], [[fedorapeople.org]]) completely from one's own laptop, using no different or additional access to any to any tool than your id has.
| | Refer to https://fedorahosted.org/FedoraReview/ |
| | |
| = Submitting Packages for Review =
| |
| | |
| == Status ==
| |
| | |
| <pre>
| |
| [cweyl@athena bin]$ time ./reviewtool status
| |
| Retrieving status from bugzilla....
| |
| | |
| Fetching bugzilla data: 100% [===================================]D 0h00m05s
| |
| | |
| .--------+---+---+---------------------------------------------------------.
| |
| | Bug | R | C | Name |
| |
| +--------+---+---+---------------------------------------------------------+
| |
| | 479218 | * | * | perl-DateTime-Format-Flexible |
| |
| | | | | NEW; last changed: 2009-01-08T00:57:33 |
| |
| | | | | R: cweyl@alumni.drew.edu |
| |
| | | | | A: nobody@fedoraproject.org |
| |
| | 479223 | * | * | perl-DateTime-Format-DateParse |
| |
| | | | | NEW; last changed: 2009-01-08T00:59:54 |
| |
| | | | | R: cweyl@alumni.drew.edu |
| |
| | | | | A: nobody@fedoraproject.org |
| |
| | 473723 | ? | * | perl-Eval-Context |
| |
| | | | | ASSIGNED; last changed: 2009-01-09T00:00:11 |
| |
| | | | | R: cweyl@alumni.drew.edu |
| |
| | | | | A: wolfy@nobugconsulting.ro |
| |
| | 478780 | + | + | perl-MooseX-Traits-Attribute-CascadeClear |
| |
| | | | | ASSIGNED; last changed: 2009-01-09T00:58:15 |
| |
| | | | | R: cweyl@alumni.drew.edu |
| |
| | | | | A: panemade@gmail.com |
| |
| '--------+---+---+---------------------------------------------------------'
| |
| </pre>
| |
| | |
| In the above table, columns R and C are the settings of flags: fedora-'''r'''eview and fedora-'''c'''vs, respectively.
| |
| | |
| == Submitting ==
| |
| | |
| <pre>
| |
| [cweyl@athena bin]$ ./reviewtool submit ~/rpms/perl-DateTime-Format-DateParse/perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm
| |
| Working on: (1 of 1) perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm
| |
| Searching bugzilla; this may take some time...
| |
| No existing review bug for perl-DateTime-Format-DateParse.
| |
| Starting koji scratch build.
| |
| ...this may take some time. We started at 2009-01-08T05:56:44
| |
| Running koji build -- this may take some time
| |
| Koji build done; we took 2 minutes, 46 seconds.
| |
| | |
| Pushing package and spec to fedorapeople...
| |
| perl-DateTime-Format-DateParse-0.04-1.fc10.sr 100% 17KB 17.4KB/s 00:00
| |
| perl-DateTime-Format-DateParse.spec 100% 1627 1.6KB/s 00:00
| |
| ...done.
| |
| | |
| #!#!#!#!#!#!#!#!#!!#!#!!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#
| |
| Pkg: perl-DateTime-Format-DateParse
| |
| Summary: Parse Date::Parse compatible formats
| |
| SRPM: perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm
| |
| | |
| // Begin request tix body //////////////////////////////////////////////
| |
| Spec URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-DateParse.spec
| |
| SRPM URL: http://fedorapeople.org/~cweyl/review/perl-DateTime-Format-DateParse-0.04-1.fc10.src.rpm
| |
| | |
| Description:
| |
| This module is a DateTime compatibility wrapper around Date::Parse; it allows
| |
| one to easily parse formats Date::Parse recognises for DateTime.
| |
| | |
| Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1039635
| |
| | |
| // End request tix body ////////////////////////////////////////////////
| |
| | |
| Post for review? y
| |
| Creating bug...
| |
| ...done.
| |
| | |
| Review bug for perl-DateTime-Format-DateParse is: 479223
| |
| </pre>
| |
| | |
| == Branching ==
| |
| | |
| <pre>
| |
| [cweyl@athena bin]$ ./reviewtool branch
| |
| Finding our submitted bugs...
| |
| Found bugs 479218, 473723, 479223.
| |
| | |
| Checking 479218 (perl-DateTime-Format-Flexible)...
| |
| 479218 not ready for branching.
| |
| | |
| Checking 473723 (perl-Eval-Context)...
| |
| 473723 not ready for branching.
| |
| | |
| Checking 479223 (perl-DateTime-Format-DateParse)...
| |
| | |
| #!#!#!#!#!#!#!#!#!!#!#!!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#!#
| |
| Bug: 479223
| |
| Summary: Review Request: perl-DateTime-Format-DateParse - Parse Date::Parse compatible formats
| |
| Status: ASSIGNED
| |
| Assignee: wolfy@nobugconsulting.ro
| |
| | |
| Last comment:
| |
| | |
| // Begin comment //////////////////////////////////////////////////////
| |
| Package Review
| |
| ==============
| |
| | |
| Key:
| |
| - = N/A
| |
| x = Check
| |
| ! = Problem
| |
| ? = Not evaluated
| |
| | |
| === REQUIRED ITEMS ===
| |
| [x] Package is named according to the Package Naming Guidelines.
| |
| [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
| |
| [x] Package meets the Packaging Guidelines including the Perl specific items
| |
| [.... snip ....]
| |
| [-] The placement of pkgconfig(.pc) files is correct.
| |
| [-] File based requires are sane.
| |
| [+] "make test" passes
| |
| | |
| | |
| ================
| |
| *** APPROVED ***
| |
| ================
| |
| // End comment ////////////////////////////////////////////////////////
| |
| | |
| Branch request:
| |
| | |
| // Begin /////////////////////////////////////////////
| |
| New Package CVS Request
| |
| =======================
| |
| Package Name: perl-DateTime-Format-DateParse
| |
| Short Description: Parse Date::Parse compatible formats
| |
| Owners: cweyl
| |
| Branches: F-9 F-10 devel
| |
| InitialCC: perl-sig
| |
| // End ///////////////////////////////////////////////
| |
| Post branch request? y
| |
| | |
| Posting...
| |
| Posted initial branch request to review bug (BZ#479223).
| |
| </pre>
| |
| | |
| == Closing a completed review ==
| |
| | |
| <pre>
| |
| [cweyl@athena bin]$ ./reviewtool close
| |
| Finding our submitted bugs...
| |
| Found bugs 479218, 479223, 473723, 478780.
| |
| | |
| Checking 479218 (perl-DateTime-Format-Flexible)...
| |
| 479218 not ready to close.
| |
| | |
| Checking 479223 (perl-DateTime-Format-DateParse)...
| |
| 479223 not ready to close.
| |
| | |
| Checking 473723 (perl-Eval-Context)...
| |
| 473723 not ready to close.
| |
| | |
| Checking 478780 (perl-MooseX-Traits-Attribute-CascadeClear)...
| |
| 478780 has been approved, branched, and is ready to close.
| |
| Close 478780? y
| |
| 478780 closed.
| |
| </pre>
| |
| | |
| The ''close'' command searches for your submitted review tix that are ready to close (fedora-review and fedora-cvs are both '+'); it then asks if you want to close.
| |
| | |
| = Reviewing Packages =
| |
| | |
| [[Category:Perl]]
| |
