< Changes
Churchyard (talk | contribs) m (Churchyard moved page Changes/Remove Python2 RPM Macros to Changes/Disable Python 2 Dist RPM Generators and Freeze Python 2 Macros: Proposal feedback) |
Churchyard (talk | contribs) (Take 2) |
||
Line 1: | Line 1: | ||
<!-- The actual name of your proposed change page should look something like: Changes/Your_Change_Proposal_Name. This keeps all change proposals in the same namespace --> | <!-- The actual name of your proposed change page should look something like: Changes/Your_Change_Proposal_Name. This keeps all change proposals in the same namespace --> | ||
= | = Disable Python 2 Dist RPM Generators and Freeze Python 2 Macros <!-- The name of your change proposal --> = | ||
== Summary == | == Summary == | ||
<!-- A sentence or two summarizing what this change is and what it will do. This information is used for the overall changeset summary page for each release. | <!-- A sentence or two summarizing what this change is and what it will do. This information is used for the overall changeset summary page for each release. | ||
Note that motivation for the change should be in the Benefit to Fedora section below, and this part should answer the question "What?" rather than "Why?". --> | Note that motivation for the change should be in the Benefit to Fedora section below, and this part should answer the question "What?" rather than "Why?". --> | ||
The {{package|python2-rpm-macros}} package ( | The `python2.7dist()` and `python2dist()` automatic provides/requires from {{package|python-rpm-generators}} will no longer be automatically generated, no packages in Fedora use them. The `python(abi) = 2.7` automatic provides/requires will be kept. | ||
The {{package|python2-rpm-macros}} package will be removed from Fedora 34 and newer. The python2 RPM macros (`/usr/lib/rpm/macros.d/macros.python2`) be moved to {{package|python2.7}} and frozen (no new development, except critical bugfixes that affect packages outside the remaining Python 2 ecosystem). | |||
Note that Python 2 packages are already not allowed in Fedora, except explicitly granted exceptions. | |||
== Owner == | == Owner == | ||
Line 25: | Line 29: | ||
== Current status == | == Current status == | ||
[[Category: | [[Category:ChangeReadyForWrangler]] | ||
<!-- When your change proposal page is completed and ready for review and announcement --> | <!-- When your change proposal page is completed and ready for review and announcement --> | ||
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler --> | <!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler --> | ||
Line 52: | Line 56: | ||
<!-- Expand on the summary, if appropriate. A couple sentences suffices to explain the goal, but the more details you can provide the better. --> | <!-- Expand on the summary, if appropriate. A couple sentences suffices to explain the goal, but the more details you can provide the better. --> | ||
Python 2 is upstream dead, usage in Fedora packages is forbidden, except for several package with an explicit FESCo approved exception. The Python Maintenance team no longer wishes to support the python2 RPM macros from the {{package|python2-rpm-macros}} package (located at `/usr/lib/rpm/macros.d/macros.python2`) and hence decided to | Python 2 is upstream dead, usage in Fedora packages is forbidden, except for several package with an explicit FESCo approved exception. The Python Maintenance team no longer wishes to support the python2 dist RPM generators from the {{package|python-rpm-generators}} package nor the python2 RPM macros from the {{package|python2-rpm-macros}} package (located at `/usr/lib/rpm/macros.d/macros.python2`) and hence decided to disable the generators for Python 2 and freeze the macros. | ||
Provides/requires like this will no longer be automatically generated in Fedora: | |||
python2dist(...) | |||
python2.7dist(...) | |||
Currently, no functional Fedora 34 packages need such provides. The `python(abi) = 2.7` automatic provides/requires will be kept. | |||
The following macro definitions will be moved from {{package|python2-rpm-macros}} to {{package|python2.7}}: | |||
%{python2_sitelib} | %{python2_sitelib} | ||
Line 70: | Line 83: | ||
%py2_install_wheel | %py2_install_wheel | ||
The following macros will remain defined for the time being to not break packages that are using Python 2 as build-time only dependency (which is also not allowed, but happens more often): | And their definition will remain frozen unless a bug is found that affects packages outside the remaining Python 2 ecosystem. Packagers of Python 2 packages affected by bugs in the macros are encouraged to apply workarounds and/or submit fixes themselves. | ||
{{package|python2.7}} will provide and obsolete {{package|python2-rpm-macros}} at least for 2 more releases (or until it is removed entirely from Fedora). | |||
The following macros will remain defined in {{package|python-srpm-macros}} for the time being to not break packages that are using Python 2 as build-time only dependency (which is also not allowed, but happens more often): | |||
%{__python2} | %{__python2} | ||
%{python2} | %{python2} | ||
The [https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#_python_2_packages Python 2 section of Python packaging guidelines] will be | The [https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#_python_2_packages Python 2 section of Python packaging guidelines] will be amended to say that the Python 2 macros may not completely mirror the Python 3 macros. | ||
The changes will happen after the Fedora 34 mass rebuild and before branching. | The changes will happen after the Fedora 34 mass rebuild and before branching. | ||
== Feedback == | == Feedback == | ||
<!-- Summarize the feedback from the community and address why you chose not to accept proposed alternatives. This section is optional for all change proposals but is strongly suggested. Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. If you get no feedback, that is useful to note in this section as well. For innovative or possibly controversial ideas, consider collecting feedback before you file the change proposal. --> | <!-- Summarize the feedback from the community and address why you chose not to accept proposed alternatives. This section is optional for all change proposals but is strongly suggested. Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. If you get no feedback, that is useful to note in this section as well. For innovative or possibly controversial ideas, consider collecting feedback before you file the change proposal. --> | ||
At first, we have [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/MGY7FJTUH5NC6EHTBIEU4TKSEKREBXTH/ proposed to remove the macros entirely]. That proposal has received negative feedback and we have reworked it to only freeze the macros and disable the dist generators. | |||
== Benefit to Fedora == | == Benefit to Fedora == | ||
Line 236: | Line 128: | ||
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo (low-level, but visible to advanced users) | https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo (low-level, but visible to advanced users) | ||
https://fedoraproject.org/wiki/Changes/VirtualBox_Guest_Integration (primarily a UX change) | https://fedoraproject.org/wiki/Changes/VirtualBox_Guest_Integration (primarily a UX change) | ||
https://fedoraproject.org/wiki/Changes/ | https://fedoraproject.org/wiki/Changes/ObserveNoMoreAlpha (an improvement to distro processes) | ||
https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack) | https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack) | ||
--> | --> | ||
With each change of the RPM Python dist generators we had to create artificial packages to test the impact on Python 2, because the real set of Python 2 package in Fedora is basically non-existent. By disabling them, we no longer have to worry about breaking things for our downstreams or projects building atop Fedora. | |||
In the past, we tried to keep the macros as similar to their Python 3 counterparts as possible, but we have decided that it is not worth it for 13 packages. This way, historical packages can still be built atop Fedora with the macros, but we don't need to worry about keeping them up-to-date. Once {{package|python2.7}} is retired, the macros will go away as well. This is also true for RHEL 9. | |||
== Scope == | == Scope == | ||
* Proposal owners: | * Proposal owners: | ||
** | ** Disable the `python2dist()`/`python2.7dist()` dependency generators. | ||
** | ** Move the python2 macros from {{package|python2-rpm-macros}} to {{package|python2.7}}. | ||
** Remove {{package|python2-rpm-macros}} and obsolete/provide it from {{package|python2.7}}. | |||
<!-- What work do the feature owners have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | <!-- What work do the feature owners have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | ||
* Other developers:<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | * Other developers: No action required.<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
<!-- What work do other developers have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | <!-- What work do other developers have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | ||
Line 257: | Line 150: | ||
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication --> | The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication --> | ||
* Policies and guidelines: the Python 2 guidelines | * Policies and guidelines: a note will be added to the Python 2 guidelines<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
<!-- Do the packaging guidelines or other documents need to be updated for this feature? If so, does it need to happen before or after the implementation is done? If a FPC ticket exists, add a link here. --> | <!-- Do the packaging guidelines or other documents need to be updated for this feature? If so, does it need to happen before or after the implementation is done? If a FPC ticket exists, add a link here. --> | ||
* Trademark approval: Not | * Trademark approval: Not necessary. | ||
<!-- If your Change may require trademark approval (for example, if it is a new Spin), file a ticket ( https://pagure.io/Fedora-Council/tickets/issues ) requesting trademark approval from the Fedora Council. This approval will be done via the Council's consensus-based process. --> | <!-- If your Change may require trademark approval (for example, if it is a new Spin), file a ticket ( https://pagure.io/Fedora-Council/tickets/issues ) requesting trademark approval from the Fedora Council. This approval will be done via the Council's consensus-based process. --> | ||
Line 270: | Line 163: | ||
<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
The {{package|python2-rpm-macros}} package will be obsoleted by {{package|python2.7}}. Users that happened to have the macros installed but not the interpreter will suddenly pull the interpreter on upgrades, but we think that's a reasonable compromise. | |||
== How To Test == | == How To Test == | ||
Line 288: | Line 181: | ||
<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
Build a Python 2 package that used to provide and/or require `python2.7dist()` or `python2dist()` automatically. Verify it does not do that. Verify it still requires `python(abi) = 2.7`. Verify the macros are still defined. Verify {{package|python2-rpm-macros}} is no more. Verify {{package|python2.7}} does not depend on RPM. | |||
== Packager Experience == | == Packager Experience == | ||
Line 301: | Line 194: | ||
- Green has been scientifically proven to be the most relaxing color. The move to a default background color of green with green text will result in Fedora users being the most relaxed users of any operating system. | - Green has been scientifically proven to be the most relaxing color. The move to a default background color of green with green text will result in Fedora users being the most relaxed users of any operating system. | ||
--> | --> | ||
Mildly | Mildly worse for packagers building Python 2 RPMs atop Fedora. If such packagers need the dist generators to do so, they are encouraged to build their own version. | ||
Fedora packages are not affected. | |||
== Dependencies == | == Dependencies == | ||
Line 312: | Line 207: | ||
<!-- If you cannot complete your feature by the final development freeze, what is the backup plan? This might be as simple as "Revert the shipped configuration". Or it might not (e.g. rebuilding a number of dependent packages). If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy. --> | <!-- If you cannot complete your feature by the final development freeze, what is the backup plan? This might be as simple as "Revert the shipped configuration". Or it might not (e.g. rebuilding a number of dependent packages). If you feature is not completed in time we want to assure others that other parts of Fedora will not be in jeopardy. --> | ||
* Contingency mechanism: | * Contingency mechanism: Orphan {{package|python2.7}}. <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
<!-- When is the last time the contingency mechanism can be put in place? This will typically be the beta freeze. --> | <!-- When is the last time the contingency mechanism can be put in place? This will typically be the beta freeze. --> | ||
* Contingency deadline: Beta freeze. <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | * Contingency deadline: Beta freeze. <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
Line 323: | Line 218: | ||
<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
This page is the documentation for the affected packagers. | This page is the documentation for the affected 3rd party packagers. | ||
== Release Notes == | == Release Notes == |
Revision as of 10:00, 19 January 2021
Disable Python 2 Dist RPM Generators and Freeze Python 2 Macros
Summary
The python2.7dist()
and python2dist()
automatic provides/requires from python-rpm-generators
will no longer be automatically generated, no packages in Fedora use them. The python(abi) = 2.7
automatic provides/requires will be kept.
The python2-rpm-macros
package will be removed from Fedora 34 and newer. The python2 RPM macros (/usr/lib/rpm/macros.d/macros.python2
) be moved to python2.7
and frozen (no new development, except critical bugfixes that affect packages outside the remaining Python 2 ecosystem).
Note that Python 2 packages are already not allowed in Fedora, except explicitly granted exceptions.
Owner
- Name: Miro Hrončok
- Email: mhroncok@redhat.com
Current status
- Targeted release: Fedora 34
- Last updated: 2021-01-19
- FESCo issue: <will be assigned by the Wrangler>
- Tracker bug: <will be assigned by the Wrangler>
- Release notes tracker: <will be assigned by the Wrangler>
Detailed Description
Python 2 is upstream dead, usage in Fedora packages is forbidden, except for several package with an explicit FESCo approved exception. The Python Maintenance team no longer wishes to support the python2 dist RPM generators from the python-rpm-generators
package nor the python2 RPM macros from the python2-rpm-macros
package (located at /usr/lib/rpm/macros.d/macros.python2
) and hence decided to disable the generators for Python 2 and freeze the macros.
Provides/requires like this will no longer be automatically generated in Fedora:
python2dist(...) python2.7dist(...)
Currently, no functional Fedora 34 packages need such provides. The python(abi) = 2.7
automatic provides/requires will be kept.
The following macro definitions will be moved from python2-rpm-macros
to python2.7
:
%{python2_sitelib} %{python2_sitearch} %{python2_version} %{python2_version_nodots} %{python2_platform} %{py2_shbang_opts} %{py2_shbang_opts_nodash} %{py2_shebang_flags} %py2_shebang_fix %py2_build %py2_build_egg %py2_build_wheel %py2_install %py2_install_egg %py2_install_wheel
And their definition will remain frozen unless a bug is found that affects packages outside the remaining Python 2 ecosystem. Packagers of Python 2 packages affected by bugs in the macros are encouraged to apply workarounds and/or submit fixes themselves.
python2.7
will provide and obsolete python2-rpm-macros
at least for 2 more releases (or until it is removed entirely from Fedora).
The following macros will remain defined in python-srpm-macros
for the time being to not break packages that are using Python 2 as build-time only dependency (which is also not allowed, but happens more often):
%{__python2} %{python2}
The Python 2 section of Python packaging guidelines will be amended to say that the Python 2 macros may not completely mirror the Python 3 macros.
The changes will happen after the Fedora 34 mass rebuild and before branching.
Feedback
At first, we have proposed to remove the macros entirely. That proposal has received negative feedback and we have reworked it to only freeze the macros and disable the dist generators.
Benefit to Fedora
With each change of the RPM Python dist generators we had to create artificial packages to test the impact on Python 2, because the real set of Python 2 package in Fedora is basically non-existent. By disabling them, we no longer have to worry about breaking things for our downstreams or projects building atop Fedora.
In the past, we tried to keep the macros as similar to their Python 3 counterparts as possible, but we have decided that it is not worth it for 13 packages. This way, historical packages can still be built atop Fedora with the macros, but we don't need to worry about keeping them up-to-date. Once python2.7
is retired, the macros will go away as well. This is also true for RHEL 9.
Scope
- Proposal owners:
- Disable the
python2dist()
/python2.7dist()
dependency generators. - Move the python2 macros from
python2-rpm-macros
topython2.7
. - Remove
python2-rpm-macros
and obsolete/provide it frompython2.7
.
- Disable the
- Other developers: No action required.
- Release engineering: no impact on Release Engineering is anticipated
- Policies and guidelines: a note will be added to the Python 2 guidelines
- Trademark approval: Not necessary.
- Alignment with Objectives: Not really.
Upgrade/compatibility impact
The python2-rpm-macros
package will be obsoleted by python2.7
. Users that happened to have the macros installed but not the interpreter will suddenly pull the interpreter on upgrades, but we think that's a reasonable compromise.
How To Test
Build a Python 2 package that used to provide and/or require python2.7dist()
or python2dist()
automatically. Verify it does not do that. Verify it still requires python(abi) = 2.7
. Verify the macros are still defined. Verify python2-rpm-macros
is no more. Verify python2.7
does not depend on RPM.
Packager Experience
Mildly worse for packagers building Python 2 RPMs atop Fedora. If such packagers need the dist generators to do so, they are encouraged to build their own version.
Fedora packages are not affected.
Dependencies
None.
Contingency Plan
- Contingency mechanism: Orphan
python2.7
. - Contingency deadline: Beta freeze.
- Blocks release? No.
- Blocks product? No.
Documentation
This page is the documentation for the affected 3rd party packagers.