From Fedora Project Wiki
< Changes
(Add trackers) |
|||
| (24 intermediate revisions by 2 users not shown) | |||
| Line 1: | Line 1: | ||
<!-- Self Contained or System Wide Change Proposal? | <!-- Self Contained or System Wide Change Proposal? | ||
Use this guide to determine to which category your proposed change belongs to. | Use this guide to determine to which category your proposed change belongs to. | ||
| Line 21: | Line 19: | ||
<!-- The actual name of your proposed change page should look something like: Changes/Your_Change_Proposal_Name. This keeps all change proposals in the same namespace --> | <!-- The actual name of your proposed change page should look something like: Changes/Your_Change_Proposal_Name. This keeps all change proposals in the same namespace --> | ||
= Use make_build and make_install macros <!-- The name of your change proposal --> = | = Use %make_build and %make_install macros <!-- The name of your change proposal --> = | ||
== Summary == | == Summary == | ||
| Line 27: | Line 25: | ||
Note that motivation for the change should be in the Benefit to Fedora section below, and this part should answer the question "What?" rather than "Why?". --> | Note that motivation for the change should be in the Benefit to Fedora section below, and this part should answer the question "What?" rather than "Why?". --> | ||
This change will | This change will increase the use of the %make_build and %make_install macros in spec files. | ||
== Owner == | == Owner == | ||
| Line 46: | Line 44: | ||
== Current status == | == Current status == | ||
[[Category: | [[Category:ChangeAcceptedF33]] | ||
<!-- When your change proposal page is completed and ready for review and announcement --> | <!-- When your change proposal page is completed and ready for review and announcement --> | ||
<!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler --> | <!-- remove Category:ChangePageIncomplete and change it to Category:ChangeReadyForWrangler --> | ||
| Line 53: | Line 51: | ||
<!-- Select proper category, default is Self Contained Change --> | <!-- Select proper category, default is Self Contained Change --> | ||
[[Category:SelfContainedChange]] | <!--[[Category:SelfContainedChange]] --> | ||
[[Category:SystemWideChange]] | |||
* Targeted release: [[Releases/33 | Fedora 33 ]] | * Targeted release: [[Releases/33 | Fedora 33 ]] | ||
| Line 65: | Line 63: | ||
CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development | CLOSED as NEXTRELEASE -> change is completed and verified and will be delivered in next release under development | ||
--> | --> | ||
* FESCo issue: | * FESCo issue: [https://pagure.io/fesco/issue/2420 #2420] | ||
* Tracker bug: | * Tracker bug: [https://bugzilla.redhat.com/show_bug.cgi?id=1858398 #1858398] | ||
* Release notes tracker: | * Release notes tracker: [https://pagure.io/fedora-docs/release-notes/issue/536 #536] | ||
== Detailed Description == | == Detailed Description == | ||
| Line 73: | Line 71: | ||
<!-- Expand on the summary, if appropriate. A couple sentences suffices to explain the goal, but the more details you can provide the better. --> | <!-- Expand on the summary, if appropriate. A couple sentences suffices to explain the goal, but the more details you can provide the better. --> | ||
The goal of this change is to standardize the usage of make in Fedora. All make invocations in spec files that | The goal of this change is to standardize the usage of make in Fedora. All make invocations in spec files that use the %{_smp_mflags} macro will be modified to use the %make_build macro, and all make invocations that use the install target will be updated to use the %make_install macro. Any additional arguments to make that are not included in either the %make_build and %make_install will be preserved. | ||
All changes will be submitted to dist-git repositories via pull requests. Pull requests will be merged after 1 week if there are no | All changes will be submitted to dist-git repositories via pull requests. Pull requests will be merged after 1 week if there are no objections or earlier if approved by the package maintainers. | ||
A script will be used to apply the necessary changes to the spec files, and the result will be manually inspected before being merged. | A script will be used to apply the necessary changes to the spec files, and the result will be manually inspected before being merged. | ||
| Line 90: | Line 84: | ||
<!-- Summarize the feedback from the community and address why you chose not to accept proposed alternatives. This section is optional for all change proposals, but is strongly suggested. Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. If you get no feedback, that is useful to note in this section as well. For innovative or possibly controversial ideas, consider collecting feedback before you file the change proposal. --> | <!-- Summarize the feedback from the community and address why you chose not to accept proposed alternatives. This section is optional for all change proposals, but is strongly suggested. Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. If you get no feedback, that is useful to note in this section as well. For innovative or possibly controversial ideas, consider collecting feedback before you file the change proposal. --> | ||
Feedback from thread on devel list: | |||
* There are concerns that replacing all make invocations with %make_build, even in cases where there may not be any benefit e.g. for `make html` may cause build failures or make the spec file less readable. An alternative to replacing all make invocations would be only to replace make in `make $BUILD_TARGET`, `make check`, and `make install` with %make_{build,install}. | |||
As a result of this feedback, the change proposal has been updated to only update `make %{_smp_mflags} ...` and `make install` with the macros. | |||
== Benefit to Fedora == | == Benefit to Fedora == | ||
| Line 120: | Line 120: | ||
https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack) | https://fedoraproject.org/wiki/Changes/perl5.26 (major upgrade to a popular software stack, visible to users of that stack) | ||
--> | --> | ||
* | * Standardized spec files. | ||
* This will make it easier to enforce consistent build flag usage across all of Fedora. | * This will make it easier to enforce consistent build flag usage across all of Fedora. | ||
| Line 131: | Line 131: | ||
<!-- What work do other developers have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | <!-- What work do other developers have to accomplish to complete the feature in time for release? Is it a large change affecting many parts of the distribution or is it a very isolated change? What are those changes?--> | ||
* Release engineering: [https://pagure.io/releng/issues # | * Release engineering: [https://pagure.io/releng/issues/9533 #9533] (a check of an impact with Release Engineering is needed) <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
<!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)? Is a mass rebuild required? include a link to the releng issue. | <!-- Does this feature require coordination with release engineering (e.g. changes to installer image generation or update package delivery)? Is a mass rebuild required? include a link to the releng issue. | ||
The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing, and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication --> | The issue is required to be filed prior to feature submission, to ensure that someone is on board to do any process development work and testing, and that all changes make it into the pipeline; a bullet point in a change is not sufficient communication --> | ||
* Policies and guidelines: Package guidelines already specify that packages should use these macros when possible. | * Policies and guidelines: Package guidelines already specify that packages should use these macros when possible. <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
<!-- Do the packaging guidelines or other documents need to be updated for this feature? If so, does it need to happen before or after the implementation is done? If a FPC ticket exists, add a link here. --> | <!-- Do the packaging guidelines or other documents need to be updated for this feature? If so, does it need to happen before or after the implementation is done? If a FPC ticket exists, add a link here. --> | ||
| Line 198: | Line 198: | ||
<!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | <!-- REQUIRED FOR SYSTEM WIDE CHANGES --> | ||
There will be no documentation updates, since this change is bringing spec files up-to-date with the current packaging guidelines. | |||
== Release Notes == | == Release Notes == | ||
Latest revision as of 19:56, 17 July 2020
Use %make_build and %make_install macros
Summary
This change will increase the use of the %make_build and %make_install macros in spec files.
Owner
- Name: Tom Stellard
- Email: <tstellar@redhat.com>
Current status
- Targeted release: Fedora 33
- Last updated: 2020-07-17
- FESCo issue: #2420
- Tracker bug: #1858398
- Release notes tracker: #536
Detailed Description
The goal of this change is to standardize the usage of make in Fedora. All make invocations in spec files that use the %{_smp_mflags} macro will be modified to use the %make_build macro, and all make invocations that use the install target will be updated to use the %make_install macro. Any additional arguments to make that are not included in either the %make_build and %make_install will be preserved.
All changes will be submitted to dist-git repositories via pull requests. Pull requests will be merged after 1 week if there are no objections or earlier if approved by the package maintainers.
A script will be used to apply the necessary changes to the spec files, and the result will be manually inspected before being merged.
All packages updated by this change request will be rebuilt after the spec file changes are merged.
Some packages already use the %make_build and %make_install macros. These packages will be left unchanged.
Feedback
Feedback from thread on devel list:
- There are concerns that replacing all make invocations with %make_build, even in cases where there may not be any benefit e.g. for
make htmlmay cause build failures or make the spec file less readable. An alternative to replacing all make invocations would be only to replace make inmake $BUILD_TARGET,make check, andmake installwith %make_{build,install}.
As a result of this feedback, the change proposal has been updated to only update make %{_smp_mflags} ... and make install with the macros.
Benefit to Fedora
- Standardized spec files.
- This will make it easier to enforce consistent build flag usage across all of Fedora.
Scope
- Proposal owners: Update spec files and submit pull requests and do new package builds. Optional: Merge pull requests (Proposal Owner would need to request to be added to provenpackagers group)
- Other developers: Package owners may merge pull requests and submit new builds if they want, but this is not required for them. A member of the provenpackagers group will be needed to merge pull requests.
- Release engineering: #9533 (a check of an impact with Release Engineering is needed)
- Policies and guidelines: Package guidelines already specify that packages should use these macros when possible.
- Trademark approval: N/A (not needed for this Change)
Upgrade/compatibility impact
No impact.
How To Test
Updated packages will be build tested using the koji-simple-ci test that is automatically run when a new pull request is created.
User Experience
End-users will not notice any changes.
Dependencies
No real dependencies, each package can be updated independently.
Contingency Plan
- Contingency mechanism: None. If not all packages are updated in time, then the work can continue into the next release.
- Contingency deadline: All work will be done in the rawhide branch, and will not be backported into the f33 branch once it is created, so whatever gets done before the branch date will make it into the release.
- Blocks release? No
- Blocks product? No
Documentation
There will be no documentation updates, since this change is bringing spec files up-to-date with the current packaging guidelines.